Add a feature flag for serialization encoding #7148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubignat
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| decoders: decoders, | ||
| }, nil | ||
| } | ||
|
|
||
| func (p *parser) ShardInfoToBlob(info *ShardInfo) (persistence.DataBlob, error) { | ||
| db := persistence.DataBlob{} | ||
| data, err := p.encoder.shardInfoToBlob(info) | ||
| encoding := p.dc.SerializationEncoding() |
There was a problem hiding this comment.
Nit:
- this checking of dynamic config might be worthwhile building into a helper?
- I don't see an obvious reason for this, so this is fine to ignore, but it'd be easy to throw the data being encoded to the dynamic-config as an an input if you wanted more granular control at runtime as a constraint?
davidporter-id-au
approved these changes
Aug 13, 2025
davidporter-id-au
approved these changes
Aug 13, 2025
ansidev
pushed a commit
to ansidev/cadence
that referenced
this pull request
Aug 27, 2025
* Add thrift_snappy endoding * Move test payloads into a common file * Add feature flag for serialization encoding * Fix tests * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a feature flag to switch between different blob encodings
Why?
To add the ability to change different blob encodings with a dynamic config
How did you test it?
Manually, and unit-tests